Skip to content

Re-enable macro annotations tests #516

Closed
@lrytz

Description

@lrytz

They were disabled in scala/scala@1190208

Thinking about it, maybe it's enough to add some unique suffix to the scala version in https://github.com/scala/scala/blob/4ffaf3935388f389d4b9034b7c0957a473cc8e84/build.sbt#L105. It's possible that using (scalaInstance in bootstrap).value.version (2.13.0-pre-SNAPSHOT) made sbt compile the compiler-interface against some different scala version using 2.13.0-pre-SNAPSHOT.

On the other hand, our "model" for the rest of the repository is: sources compiled in the sbt session are compiled with the "starr" compiler, not the one built by the project. Tests that actually test the bootstrapped compiler are in partest. It might be cleaner to follow the same pattern for macro annotation tests, i.e., move them to partest.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions