Fix ArrayIndexOutOfBoundsException in mutable.BitSet.<<= #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linasm
force-pushed
the
fix-aioobe-in-mutable-bitset-shift-left
branch
from
ae0abe8 to
2cbdde4
Compare
Member
|
is there someone watching this repo who can review this? |
Member
|
I'll just go ahead and merge it, then :-) thanks @linasm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ArrayIndexOutOfBoundsExceptionthat is thrown by<<=operation onmutable.BitSetconsisting of more than one empty word.Such
BitSetis possible in practice, even though it seems to contradict the invariant prescribed in the documentation ("The memory footprint of a bitset is determined by the largest number stored in it."). See the added test case for an example.