Fix migration tool installation instructions #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Maxime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245.
As
scala-collection-migrationswas not a part of the 2.1.2 release, this PR removes all mention of a 2.1.2 version ofscala-collection-migrationsin the README. Instead, it updates installation instructions to 2.1.1, which I suppose is the only way to mitigate the issue raised in #245.This PR is related to #264, which fixed the instructions for the
Collection213Upgraderewrite, but not for theCollection213CrossCompatrewrite.I also added a line with
addCompilerPlugin(scalafixSemanticdb). The scalafix instructions mandate using this, but the instructions here don't contain the line. While the README does say to follow the installation instructions in scalafix, I think it makes for a better user experience to outline the steps here too.With these updated instructions, I was able to run the migration rules without errors on my project.