Skip to content

Import travis caching config and JDK install from scala-dev #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Import travis caching config and JDK install from scala-dev #273

merged 1 commit into from
Dec 9, 2019

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Dec 3, 2019

No description provided.

@lrytz
Copy link
Member Author

lrytz commented Dec 3, 2019

Here's the reason why the CLA check fails regularly:

https://travis-ci.org/scala/scala-collection-compat/jobs/620201244?utm_medium=notification&utm_source=github_status

{ "message": "API rate limit exceeded for 35.202.245.105. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)", "documentation_url": "https://developer.github.com/v3/#rate-limiting" }

@lrytz
Copy link
Member Author

lrytz commented Dec 3, 2019

Anyone has an idea how to work around this? We could create an access token for some user, but we cannot store that in an encrypted variable on travis, as those are not available to pull request builds. Maybe a small proxy app that runs somewhere and does the check?

@lrytz
Copy link
Member Author

lrytz commented Dec 3, 2019

https://colineberhardt.github.io/cla-bot/ seems to cover everything we need, i'll give it a try. it can be enabled all of the repos in the scala organization.

@lrytz
Copy link
Member Author

lrytz commented Dec 3, 2019

almost works for us, but would need a few tweaks, so we'd have to propose some changes or run our own. anyway - suggestions welcome, looking for a simple solution :)

@lrytz
Copy link
Member Author

lrytz commented Dec 9, 2019

Merging this for now, will come back to the CLA checker issue.

@lrytz lrytz merged commit cefe0dc into scala:master Dec 9, 2019
@lrytz lrytz deleted the travis-import branch December 9, 2019 14:06
@SethTisue
Copy link
Member

on recent PRs and publishing jobs I've noticed occasional CLA check fails, but not a high percentage. they go away by hitting the restart button in Travis-CI. it's a bit annoying, but not a serious hindrance

@lrytz
Copy link
Member Author

lrytz commented Dec 12, 2019

Created https://github.com/scala/scala-collection-compat/issues/280 for the CLA discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants