Liveness analysis to avoid memory retention issues #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phaller
commented
Oct 22, 2013
phaller
commented
- Adds an iterative, backwards data-flow analysis
- Make sure fields captured by nested defs are never zeroed out. This is done elegantly by declaring such fields a being live at the exit of the final state; thus, they will never be zeroed out.
- Iterative, backwards data-flow analysis - Make sure fields captured by nested defs are never zeroed out. This is done elegantly by declaring such fields a being live at the exit of the final state; thus, they will never be zeroed out.
- A missing condition could cause an infinite loop - Various clean-ups
- Adds a hook that lets a derived macro insert additional code when zero-ing out a lifted field. - Adds a variant of the `AsyncId` macro that logs zeroed-out fields. - Adds a test using this mechanism
- Zero out fields of type Any - Zero out fields of value class type
|
Review by @retronym |
| protected[async] override def nullOut(u: Universe)(name: u.Expr[String], v: u.Expr[Any]): u.Expr[Unit] = | ||
| u.reify { scala.async.internal.AsyncTestLV(name.splice, v.splice) } | ||
| } | ||
|
|
There was a problem hiding this comment.
It would be even nicer to define this in our test sources. But that will require us to rework the build a little bit as we need to separately compile this from the tests themselves. We can leave that as a todo before 1.0.
|
LGTM. Nice small patch! |
retronym
added a commit
that referenced
this pull request
Oct 26, 2013
Liveness analysis to avoid memory retention issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.