Skip to content

Various clean-ups and docs #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 18, 2013
Merged

Various clean-ups and docs #34

merged 4 commits into from
Oct 18, 2013

Conversation

phaller
Copy link
Contributor

@phaller phaller commented Oct 18, 2013

  • Updates Scala and sbt versions
  • Minor clean-ups in code and doc comments
  • Simplifies a generated CaseDef tree in resume

@phaller
Update Scala and sbt versions
d1640f5
@phaller
Minor clean-ups
3e4ebed
@phaller
Simplify a generated CaseDef tree in resume method
d1e267b 
OLD:

    case (throwable @ _) if NonFatal.apply(throwable) => {
      {
        stateMachine$1.this.result.complete(Failure.apply[Nothing](throwable));
        ()
      };
      ()
    }

NEW:

    case (throwable @ _) if NonFatal.apply(throwable) => {
      stateMachine$1.this.result.complete(Failure.apply[Nothing](throwable));
      ()
    }
@phaller
More complete doc comments
01e3d36
@phaller
Copy link
Contributor Author

phaller commented Oct 18, 2013

Review by @retronym

@retronym
Copy link
Member

LGTM.

retronym added a commit that referenced this pull request Oct 18, 2013
@retronym
Merge pull request #34 from phaller/topic/docs-cleanups
9ecbb7a 
Various clean-ups and docs
@retronym retronym merged commit 9ecbb7a into scala:master Oct 18, 2013
@phaller phaller deleted the topic/docs-cleanups branch November 14, 2013 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@phaller @retronym