Skip to content

Noop merge of 2.10.x to master. #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 30, 2015

Conversation

retronym
Copy link
Member

No description provided.

retronym added 8 commits July 27, 2015 13:02
Update SBT for the warn command, now assumed by sbt-extras
Don't bother adding `{ ...; () }` if we can use the original tree(s) instead,
e.g. if the last tree in `...` conforms to `Unit`.

This makes the debug output of the macro a little easier to read.

(cherry picked from commit de641dc)
If we blindly splicing `{..$stats, ..$generatedCode}`, and the last
expression in `$stats` is of type `Nothing`, we'll incur a dead
code warning when typechecking the block.

This commit:
  - introduces a helper method to augment user-written stats with
    synthetic code
  - Emit a try/finally in that code (so we advance the state, even if we
    are about to exit the state machine in the async-block global
    exception handler
  - Hide `Nothing` typed expressions from the dead code analysis
    by wrapping them in an `expr: Any`

Fixes scala#150 (the part reported in the comments, not the original ticket.)
By declararing the parameter of `async` as by-name.

Fixes scala#150 (the bug in the original ticket.)

(cherry picked from commit 4b1dbee)
This avoids leaving .class files in the working directory
after running the test.

(cherry picked from commit 5bb93b0)
And remove unused code.

(cherry picked from commit 7238bc1)
retronym added a commit that referenced this pull request Jul 30, 2015
@retronym retronym merged commit 700171c into scala:master Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant