Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we can unfork coursier-using projects now (if version is new enough) #629

Closed
SethTisue opened this issue Nov 16, 2017 · 6 comments
Closed
Assignees

Comments

@SethTisue
Copy link
Member

we have a number of projects that we had to fork because they are using coursier. it would be nice if we didn't have to fork for that reason — it has now become (I think) the most common reason we have to fork

perhaps some fix is needed in dbuild, or in coursier? or can we configure our way around whatever the problem is?

@SethTisue
Copy link
Member Author

I don't think we have recently tried to see if the problem persists with the latest coursier release

and I also don't think we have made any effort to find out what's going wrong, exactly, and where a fix might be needed

@SethTisue
Copy link
Member Author

https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2189/consoleFull is an experiment re-adding coursier to an arbitrarily chosen project, namely case-app (chosen because it has few dependencies)

the coursier version used is the latest release, 1.0.0-RC13

@SethTisue
Copy link
Member Author

well color me surprised but also tickle me pink: [info] Project case-app----------------: SUCCESS (project rebuilt ok)

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

SethTisue commented Nov 19, 2017

fs2 worked, the failure was in some downstream project, since I pulled in some newer changes in addition to the coursier reinstatement.

so this is looking good, I'll just need to chip away it one project at a time

fyi @alexarchambault

@SethTisue SethTisue self-assigned this Nov 19, 2017
@SethTisue SethTisue changed the title must we fork all projects that use coursier? we can unfork coursier-using projects now (if version is new enough) Nov 19, 2017
@SethTisue
Copy link
Member Author

I think there are no remaining projects that we have forked only because of coursier. So I'm going to close this, and just keep in mind that we should keep an eye out for further unforking opportunities.

dwijnand added a commit that referenced this issue Dec 14, 2017
No longer need to use the fork with coursier removed (#629) or sbt-microsite upgraded (47degrees/sbt-microsites#248 + circe/circe#803).
@dwijnand dwijnand mentioned this issue Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant