Deprecate shifting int by long

[adriaanm]

See scala/scala3#2968, #9516

[eed3si9n]

Is this a good first issue?

[SethTisue]

I think so. deprecations and removals are usually among the easiest tasks.

[thestuckster]

I'd like to take look into this if anyone can point me in the right direction

[SethTisue]

@thestuckster you could start by writing the tests that you'd like to succeed, and verify that they fail

as for where in the compiler code to even find where "shifting int by long" is, I would have suggested looking at scala/scala#5117, but looks like it only affects code in the back end, but we'd want to report the error much earlier. another thought would be to try to think of a similar, already existing warning and then see how it's implemented.

that's one increment of advice — further increments of advice are available if you let us know how you're doing

[sjrd]

Those things are methods, declared in Int.scala. You should be able to mark them as @deprecated, as virtually any library method. Although this file is actually generated from a script in GenerateAnyVals.scala, which is probably the source you want to actually modify.

[SethTisue]

@thestuckster I just noticed that a PR on this, by @sh0hei, exists at scala/scala#6370, but marked as WIP

[thestuckster]

@SethTisue thanks for the heads up

[lrytz]

fixed in scala/scala#6680