Skip to content

Conversation

samspills
Copy link
Contributor

@samspills samspills commented Sep 24, 2025

  • not sure if I have all the correct packages here, is it necessary to ignore everything in the same release?

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (c192cd1) to head (61c5376).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3714   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         174      174           
  Lines        5049     5049           
  Branches      493      493           
=======================================
  Hits         4532     4532           
  Misses        517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rossabaker
Copy link
Contributor

Only http4s-dsl-0.23.31 is bad, but I don't know what ignoring just that one does when these all come from the same repository.

@samspills samspills marked this pull request as ready for review September 24, 2025 17:57
Copy link
Contributor

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is bigger than it needs to be, but I am confident it does the right thing and I don't understand the full ramifications of calling out just the http4s-dsl, so, 👍.

@mzuehlke
Copy link
Member

I think this is bigger than it needs to be, but I am confident it does the right thing and I don't understand the full ramifications of calling out just the http4s-dsl, so, 👍.

I think if you define the versions individually like:

val http4s = Seq(
  "org.http4s" %% "http4s-blaze-server" % "0.21.0-M6",
  "org.http4s" %% "http4s-circe"        % "0.21.0-M6",
  "org.http4s" %% "http4s-dsl"          % "0.21.0-M6",
  "io.circe"   %% "circe-derivation"    % "0.12.0-M7" % Compile,
  "io.circe"   %% "circe-fs2"           % "0.12.0"
)

and we would only ignore http4s-dsl, Steward would update the other artifacts.

@mzuehlke mzuehlke merged commit 99fb2e9 into scala-steward-org:main Sep 24, 2025
10 checks passed
@rossabaker
Copy link
Contributor

We probably would have been fine as long as nothing pulled in something that depends on http4s-dsl (i.e., http4s-core would have been fine.). But this requires is less thinking, and it was superseded within a day, so I think we did the right thing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants