Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable built-in Scala CLI rules in Scalafix migrations #3574

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Feb 2, 2025

When running Scalafix migrations in Scala CLI builds, we disable built-in Scala CLI rules so that any changes are only coming from the Scalafix migrations.

See #3486 (comment).

When running Scalafix migrations, we disable [built-in Scala CLI
rules](https://scala-cli.virtuslab.org/docs/commands/fix/#built-in-rules)
so that any changes are only coming from the Scalafix migrations.
@fthomas fthomas added bug Something isn't working cat:build-tool labels Feb 2, 2025
@fthomas fthomas added this to the 0.33.0 milestone Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (3f58890) to head (3c332da).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3574   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         174      174           
  Lines        5029     5029           
  Branches      491      491           
=======================================
  Hits         4516     4516           
  Misses        513      513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthomas fthomas merged commit 0171537 into main Feb 8, 2025
18 checks passed
@fthomas fthomas deleted the topic/scala-cli-disable-builtin-rules branch February 8, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cat:build-tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant