Run Mill 0.11 with --disable-ticker instead of --ticker false
#3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running Mill 0.11 with `--ticker=false` (which has been added in #3511) produces the following error: ``` Parsing exception Position 1:9, found "=false" ``` The `--ticker <bool>` option has been added to Mill in 0.12.0 if I'm reading [this commit](com-lihaoyi/mill@0c44ffa) correctly. We therefore need to use `--disable-ticker` with Mill 0.11 and `--ticker false` with Mill >= 0.12.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3538 +/- ##
==========================================
+ Coverage 89.77% 89.79% +0.01%
==========================================
Files 171 171
Lines 4979 4978 -1
Branches 496 490 -6
==========================================
Hits 4470 4470
+ Misses 509 508 -1 ☔ View full report in Codecov by Sentry. |
mzuehlke
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Mill 0.11 with
--ticker=false(which has been added in #3511) produces the following error:The
--ticker <bool>option has been added to Mill in 0.12.0 if I'm reading this commit correctly. We therefore need to use--disable-tickerwith Mill 0.11 and--ticker falsewith Mill >= 0.12.