Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for --signoff #3427

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

michaelmior
Copy link
Contributor

@michaelmior michaelmior commented Oct 8, 2024

This should fix #2408

@michaelmior michaelmior marked this pull request as ready for review October 8, 2024 18:48
Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@mzuehlke mzuehlke merged commit bd672e3 into scala-steward-org:main Oct 8, 2024
5 checks passed
@michaelmior
Copy link
Contributor Author

@mzuehlke Thanks! Would there be any chance of having this enabled for the public instance? If preferred, I can add a repo config option as an alternative.

@mzuehlke
Copy link
Member

mzuehlke commented Oct 9, 2024

Enabling this by default for all repos is something I wouldn't prefer.
But having this as an option in the per repo config file (https://github.com/scala-steward-org/scala-steward/blob/main/docs/repo-specific-configuration.md), to turn this on, sounds like a good idea to me 👍

@michaelmior michaelmior deleted the signoff branch October 9, 2024 16:28
@michaelmior
Copy link
Contributor Author

@mzuehlke That makes sense. See #3432

@mzuehlke mzuehlke added the enhancement New feature or request label Oct 18, 2024
@mzuehlke mzuehlke added this to the 0.31.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Sign-off the Git commit
2 participants