Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-arch image support by moving to temurin 21 #3417

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

barryoneill
Copy link
Contributor

Addresses #2590

See: https://adoptium.net/supported-platforms/ for architecture matrix

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I am also not using the docker image.
So I am waiting for feedback from the other maintainers before merging.

@mzuehlke mzuehlke merged commit 8060406 into scala-steward-org:main Sep 25, 2024
6 checks passed
@barryoneill
Copy link
Contributor Author

Hi @mzuehlke - thanks for the help. I think though there's going to be more to this. While the contents of the image are now multi-arch friendly, I think the current CI setup is still building a single-architecture image. I'm not familiar with the sbt-ecr plugin (I abandoned it years ago in favour of native Docker configuration), but I'll try and figure out what's needed.

@barryoneill
Copy link
Contributor Author

oops, meant to comment on the issue. Moving there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants