Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .sdkmanrc to the default file extensions of files to update #3416

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Add .sdkmanrc to the default file extensions of files to update #3416

merged 2 commits into from
Sep 23, 2024

Conversation

achinaou
Copy link
Contributor

closes #3414

@achinaou achinaou changed the title Add .sdkmanrc to the default file extensions of files to update Add .sdkmanrc to the default file extensions of files to update Sep 23, 2024
@exoego exoego added the enhancement New feature or request label Sep 23, 2024
exoego
exoego approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File extensions are used here:

scala-steward/modules/core/src/main/scala/org/scalasteward/core/edit/update/ScannerAlg.scala

Line 69 in b7dbc0b

.filter(path => config.updates.fileExtensionsOrDefault.exists(path.endsWith))

Looks good to me

@exoego exoego merged commit 96db7ad into scala-steward-org:main Sep 23, 2024
4 checks passed
@mzuehlke mzuehlke added this to the 0.31.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

Update Scala version in .sdkmanrc
3 participants
@achinaou @exoego @mzuehlke