Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more Mill buildfiles (build.mill, build.mill.scala) #3410

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Support more Mill buildfiles (build.mill, build.mill.scala) #3410

merged 2 commits into from
Sep 17, 2024

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 17, 2024 •
edited
Loading

Mill 0.12 will support more build file names.

  • build.sc
  • build.mill
  • build.mill.scala

This change makes sure Scala Steward will detect these.

Fix #3409

@lefou lefou marked this pull request as ready for review September 17, 2024 07:44
mzuehlke
mzuehlke approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@mzuehlke mzuehlke merged commit 554889c into scala-steward-org:main Sep 17, 2024
4 checks passed
@lefou lefou deleted the lefou-more-mill-files branch September 17, 2024 08:24
@mzuehlke mzuehlke added the enhancement New feature or request label Oct 18, 2024
@lefou
Copy link
Member Author

lefou commented Nov 4, 2024

Can we please have a new release including this change?

@mzuehlke mzuehlke added this to the 0.31.0 milestone Nov 4, 2024
@fthomas
Copy link
Member

fthomas commented Jan 1, 2025

One thing is missing here for Scala Steward to actually update versions in build.mill files. It now can extract versions from that file but UpdatesConfig.defaultFileExtensions needs to be updated so that Scala Steward also edit build.mill files.

fthomas added a commit that referenced this pull request Jan 1, 2025
@fthomas
Allow editing *.mill files
6770895 
This is an follow-up to #3410 (comment)
@fthomas fthomas mentioned this pull request Jan 1, 2025
Merged
@fthomas
Copy link
Member

fthomas commented Jan 11, 2025

Another thing I just noticed is that this line
https://github.com/lefou/scala-steward/blob/58a6a29e94e1626051c1ed4916965df5727eccef/modules/core/src/main/scala/org/scalasteward/core/buildtool/mill/MillAlg.scala#L108 wasn't updated which means that we aren't extracting plugins from build.mill files. I guess this should have been updated, too?

@fthomas fthomas mentioned this pull request Jan 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzuehlke mzuehlke mzuehlke approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

Detect more Mill setups (build.mill, build.mill.scala)
3 participants
@lefou @fthomas @mzuehlke