Recognize hashes if they are preceded by . or _
#3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows hashes to also be separated with a `.` and `_` from the
preceding component.
Here is for example what `Version.Component.parse("1.0.0+1320.38b57aa")`
returned before this change and what it returns now:
```
before:
Numeric(1), Separator(.), Numeric(0), Separator(.), Numeric(0), Separator(+),
Numeric(1320), Separator(.), Numeric(38), Alpha(b), Numeric(57), Alpha(aa)
now:
Numeric(1), Separator(.), Numeric(0), Separator(.), Numeric(0), Separator(+),
Numeric(1320), Separator(.), Hash(38b57aa))
```
Btw, recognizing hashes was added in #1549 but that PR gives no
explanation why they only could preceded by `-` and `+`.
Closes #3124
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3260 +/- ##
==========================================
- Coverage 91.19% 91.18% -0.01%
==========================================
Files 167 167
Lines 3406 3405 -1
Branches 316 306 -10
==========================================
- Hits 3106 3105 -1
Misses 300 300 ☔ View full report in Codecov by Sentry. |
exoego
approved these changes
Jan 6, 2024
fthomas
changed the title
. and _. or _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows hashes to also be separated with a
.and_from the preceding component.Here is for example what
Version.Component.parse("1.0.0+1320.38b57aa")returned before this change and what it returns now:Recognizing hashes was added in #1549 but that PR gives no explanation why they only could preceded by
-and+.Closes #3124