-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to upgrade to Scala.js 1.15.0 #3258
Conversation
Still a draft, because we need to figure out how to exclude the new /cc @sjrd |
7ee45e7
to
41ed835
Compare
We add new ignore rules for the new scalajs-scalalib artifact introduced in Scala.js 1.15.0.
41ed835
to
0809ada
Compare
I found what I needed :) Please review by @sjrd in addition to a reviewer for scala-steward. (Sorry, I can't assign a reviewer). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 167 167
Lines 3405 3405
Branches 306 306
=======================================
Hits 3105 3105
Misses 300 300 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From steward side this looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new scheme for scalajs-scalalib
looks good to me.
No description provided.