Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to upgrade to Scala.js 1.15.0 #3258

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Dec 31, 2023

No description provided.

@gzm0
Copy link
Contributor Author

gzm0 commented Dec 31, 2023

Still a draft, because we need to figure out how to exclude the new scalajs-scalalib_2.13 artifacts (they contain the Scala.js version in the build metadata, e.g. 2.13.12+1.15.0).

/cc @sjrd

We add new ignore rules for the new scalajs-scalalib artifact
introduced in Scala.js 1.15.0.
@gzm0 gzm0 marked this pull request as ready for review December 31, 2023 14:52
@gzm0
Copy link
Contributor Author

gzm0 commented Dec 31, 2023

I found what I needed :) Please review by @sjrd in addition to a reviewer for scala-steward. (Sorry, I can't assign a reviewer).

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aee074d) 91.18% compared to head (0809ada) 91.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3258   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files         167      167           
  Lines        3405     3405           
  Branches      306      306           
=======================================
  Hits         3105     3105           
  Misses        300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From steward side this looks good 👍

Copy link
Contributor

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new scheme for scalajs-scalalib looks good to me.

@fthomas fthomas merged commit 7c33066 into scala-steward-org:main Dec 31, 2023
@gzm0 gzm0 deleted the scala-js-1.15.0 branch January 1, 2024 12:08
@mzuehlke mzuehlke added this to the 0.29.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants