Remove repo from function for modifying requests #3252
Merged
+71
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the unnecessary `Repo` parameter from the function for modifying requests to add authentication headers. This parameter was added in #373 but wasn't ever used as can be observed in the diff of `ForgeSelection`. My motivation for adding `Repo` back then was to eventually use different credentials for different repositories for proper GitHub App support. But #3250 demonstrates that we can achieve this without this extra parameter.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3252 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 167 167
Lines 3404 3404
Branches 306 306
=======================================
Hits 3104 3104
Misses 300 300 ☔ View full report in Codecov by Sentry. |
mzuehlke
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unnecessary
Repoparameter from the function for modifying requests to add authentication headers. This parameter was added in #373 but wasn't ever used as can be observed in the diff ofForgeSelection. My motivation for addingRepoback then was to eventually use different credentials for different repositories for proper GitHub App support. But #3250 demonstrates that we can achieve this without this extra parameter.