Remove StewardContext hierarchy
#3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `Context.StewardContext` hierarchy. IMO `StewardContext` makes `Context.scala` unnecessarily more complicated only for saving one `case` in `Main.run`.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
==========================================
- Coverage 91.26% 91.17% -0.10%
==========================================
Files 165 166 +1
Lines 3402 3400 -2
Branches 310 310
==========================================
- Hits 3105 3100 -5
- Misses 297 300 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Context.StewardContexthierarchy. IMOStewardContextmakesContext.scalaunnecessarily more complicated only for saving onecaseinMain.runand a little duplication.