`Unknown method java.nio.file.attribute.PosixFileAttributeView.readAttributes(): java.nio.file.attribute.PosixFileAttributes`

[lihaoyi]

Noticed when trying to add permissions preservation to OS-Lib's new Zip API com-lihaoyi/os-lib#316

[error] Unknown method java.nio.file.attribute.PosixFileAttributeView.readAttributes(): java.nio.file.attribute.PosixFileAttributes, referenced from:
 private method os.zip$.zipFile(java.io.File, java.util.zip.ZipOutputStream, bool, bool): scala.runtime.BoxedUnit at ZipOps.scala:226
 private method os.zip$.createNewZip$$anonfun$1(scala.collection.immutable.List, scala.collection.immutable.List, bool, bool, java.util.zip.ZipOutputStream, java.nio.file.Path): scala.runtime.BoxedUnit at ZipOps.scala:104
         method os.zip$$$Lambda$5.applyVoid(java.lang.Object): scala.runtime.BoxedUnit at ZipOps.scala:106
 private method os.zip$.createNewZip(java.nio.file.Path, scala.collection.immutable.List, scala.collection.immutable.List, scala.collection.immutable.List, bool, bool): scala.runtime.BoxedUnit at ZipOps.scala:106
         method os.zip$.apply(os.Path, scala.collection.immutable.List, bool, scala.collection.immutable.List, scala.collection.immutable.List, scala.collection.immutable.List, bool, bool): os.Path at ZipOps.scala:66
 private method test.os.ZipOpTests$.tests$$anonfun$1$$anonfun$9$$anonfun$1$$anonfun$1(os.Path): scala.runtime.BoxedUnit at ZipOpTests.scala:292
         method test.os.ZipOpTests$$$Lambda$42.applyVoid(java.lang.Object): scala.runtime.BoxedUnit at ZipOpTests.scala:302
 private method test.os.ZipOpTests$.tests$$anonfun$1$$anonfun$9$$anonfun$1(): scala.util.Either at ZipOpTests.scala:302
         method test.os.ZipOpTests$$$Lambda$43.apply(): java.lang.Object at ZipOpTests.scala:18
 private method test.os.ZipOpTests$.tests$$anonfun$1$$anonfun$9(): scala.util.Either at ZipOpTests.scala:18
         method test.os.ZipOpTests$$$Lambda$52.apply(): java.lang.Object at ZipOpTests.scala:18
 private method test.os.ZipOpTests$.tests$$anonfun$1(): scala.util.Either at ZipOpTests.scala:18
         method test.os.ZipOpTests$$$Lambda$1.apply(): java.lang.Object at ZipOpTests.scala:18
         method test.os.ZipOpTests$.tests(): utest.Tests at ZipOpTests.scala:18
         method utest.runner.BaseRunner.runSuite(scala.collection.immutable.Seq, java.lang.String, sbt.testing.EventHandler, sbt.testing.TaskDef, scala.collection.immutable.Seq): scala.concurrent.Future at BaseRunner.scala:174
 private method utest.runner.BaseRunner.makeTask$$anonfun$1(sbt.testing.TaskDef, scala.collection.immutable.Seq, scala.collection.immutable.Seq, sbt.testing.EventHandler): scala.concurrent.Future at BaseRunner.scala:208
         method utest.runner.BaseRunner$$Lambda$16.apply(java.lang.Object, java.lang.Object): java.lang.Object at BaseRunner.scala:208
 private method utest.runner.BaseRunner.makeTask(sbt.testing.TaskDef, scala.collection.immutable.Seq): sbt.testing.Task at BaseRunner.scala:208
 private method utest.runner.BaseRunner.tasks$$anonfun$3(scala.Tuple3): sbt.testing.Task at BaseRunner.scala:80
         method utest.runner.BaseRunner$$Lambda$8.apply(java.lang.Object): java.lang.Object at BaseRunner.scala:80
         method utest.runner.BaseRunner.tasks(sbt.testing.TaskDef[]): sbt.testing.Task[] at BaseRunner.scala:80
         method utest.runner.Framework.slaveRunner(java.lang.String[], java.lang.String[], java.lang.ClassLoader, scala.Function1): sbt.testing.Runner at Framework.scala:83
 private method scala.scalanative.testinterface.TestAdapterBridge.createRunnerFun$$anonfun$1(bool, scala.scalanative.testinterface.common.RunnerArgs): scala.runtime.BoxedUnit at TestAdapterBridge.scala:41
         method scala.scalanative.testinterface.TestAdapterBridge$$Lambda$2.applyVoid(java.lang.Object): scala.runtime.BoxedUnit at TestAdapterBridge.scala:61
 private method scala.scalanative.testinterface.TestAdapterBridge.createRunnerFun(bool): scala.Function1 at TestAdapterBridge.scala:61
         method scala.scalanative.testinterface.TestAdapterBridge.start(): scala.runtime.BoxedUnit at TestAdapterBridge.scala:16
         method scala.scalanative.testinterface.TestMain$.main(java.lang.String[]): scala.runtime.BoxedUnit at TestMain.scala:94
  static method scala.scalanative.testinterface.TestMain.main(java.lang.String[]): scala.runtime.BoxedUnit at TestMain.scala:61

[JD557]

The method seems to be implemented, but I suspect that the only thing wrong is the signature:

scala-native/javalib/src/main/scala/java/nio/file/attribute/PosixFileAttributeViewImpl.scala

Line 88 in fa40ec9

override def readAttributes(): BasicFileAttributes = attributes

(returns BasicFileAttributes while the override in https://docs.oracle.com/javase/8/docs/api/java/nio/file/attribute/PosixFileAttributeView.html#readAttributes-- returns PosixFileAttributes)

[lihaoyi]

Yeah if I'm not mistaken signature needs to match exactly, so in this case we would need to add an override that narrows the return type

[LeeTibbert]

@lihaoyi , @JD557

If it does not inconvenience either of you, I'm taking a run at fixing this.

I think that the Posix declaration should be homologous/parallel/dual to
the DOS declaration. There is an underlying tangle and, as always,
a concern for maintaining binary compatibility. The offending code
is 7 or so year old, so I doubt anybody is using it but no sense in
breaking things unless necessary.

Let's see how far I get.

[JD557]

If it does not inconvenience either of you, I'm taking a run at fixing this.

For sure it does not inconvenience me, I replied instead of sending a PR because I'm having some issues building Scala Native locally.

And also, since I mostly use Windows for the Scala Native work, I don't feel comfortable working on POSIX issues 😅

[LeeTibbert]

PR #4069 passes CI and the test I created for the reported defect.

I hope it solves the problem. If not, please yell!

For sure it does not inconvenience me, I replied instead of sending a PR because I'm having some issues
building Scala Native locally.

I just just ran the next leg of the relay: teamwork.

And also, since I mostly use Windows for the Scala Native work, I don't feel comfortable working on POSIX issues 😅
That is OK, I don't either. I find them to be meditations on humility.

[LeeTibbert]

JD557 You mentioned SN build issues. Best guess: Do you think they are specific to your system, to Windows, or cruft
which may have crept into mainline SN?

Issues with private builds can be the pits and quite discouraging.