Skip to content

Opt: Remove useless *Ident indirections in the IR model. #5092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Opt: Remove useless *Ident indirections in the IR model. #5092

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d65f79
Improve test suite error messages when `HashersTest` fails.
sjrd Dec 21, 2024
5dc4127
Directly store a LocalName inside VarRef, instead of a LocalIdent.
sjrd Dec 21, 2024
2ba9ea7
Remove `LabelIdent`. Directly store `LabelName` instead.
sjrd Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Improve test suite error messages when HashersTest fails.
  • Loading branch information
@sjrd
sjrd committed Dec 21, 2024
commit 3d65f79a9bb7f9c2d864db5208bd41b30be5cda7
6 changes: 2 additions & 4 deletions ir/shared/src/test/scala/org/scalajs/ir/HashersTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,9 @@ class HashersTest {
out.close()
out.toByteArray()
}
val actualString = actualBytes.map(b => "%02x".format(b & 0xff)).mkString

val expectedBytes = expected.grouped(2)
.map(Integer.parseInt(_, 16).toByte).toArray

assertArrayEquals(expectedBytes, actualBytes)
assertEquals(expected, actualString)
}

private val bodyWithInterestingStuff = Block(
Expand Down