Skip to content

Parallelize the Analyzer #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 28, 2023
Merged

Parallelize the Analyzer #4897

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0f3ba71
Make class loading thread safe
gzm0 Jul 30, 2023
530a704
Make error collection thread-safe
gzm0 Aug 18, 2023
c857067
Make module dependency collection thread-safe
gzm0 Aug 19, 2023
6e9a0c9
Make topLevelExportInfo collection thread-safe
gzm0 Aug 19, 2023
9450a37
Make MethodInfo management thread-safe
gzm0 Aug 19, 2023
eb8f45b
Make from collection thread-safe
gzm0 Aug 19, 2023
d7d915a
Make jsNativeMember collection thread-safe
gzm0 Aug 19, 2023
4d8ffce
Make field collection thread-safe
gzm0 Aug 19, 2023
f7d6db5
Make reachability flags thread-safe
gzm0 Aug 19, 2023
355ca93
Make method dispatch thread-safe
gzm0 Aug 19, 2023
0da7a54
Parallel analyzer
gzm0 Aug 19, 2023
a28fa78
Rewrite computeMostSpecificProxyMatch
gzm0 Aug 19, 2023
9a0143c
Honor the `parallel` flag in the Analyzer
gzm0 Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make field collection thread-safe
  • Loading branch information
@gzm0
gzm0 committed Aug 23, 2023
commit 4d8ffce23f6a562cee905042e2393215695e0a56
23 changes: 15 additions & 8 deletions linker/shared/src/main/scala/org/scalajs/linker/analyzer/Analyzer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,15 @@ final class Analyzer(config: CommonPhaseConfig, initial: Boolean,
var areInstanceTestsUsed: Boolean = false
var isDataAccessed: Boolean = false

val fieldsRead: mutable.Set[FieldName] = mutable.Set.empty
val fieldsWritten: mutable.Set[FieldName] = mutable.Set.empty
val staticFieldsRead: mutable.Set[FieldName] = mutable.Set.empty
val staticFieldsWritten: mutable.Set[FieldName] = mutable.Set.empty
private[this] val _fieldsRead: mutable.Map[FieldName, Unit] = emptyThreadSafeMap
private[this] val _fieldsWritten: mutable.Map[FieldName, Unit] = emptyThreadSafeMap
val _staticFieldsRead: mutable.Map[FieldName, Unit] = emptyThreadSafeMap
val _staticFieldsWritten: mutable.Map[FieldName, Unit] = emptyThreadSafeMap

def fieldsRead: scala.collection.Set[FieldName] = _fieldsRead.keySet
def fieldsWritten: scala.collection.Set[FieldName] = _fieldsWritten.keySet
def staticFieldsRead: scala.collection.Set[FieldName] = _staticFieldsRead.keySet
def staticFieldsWritten: scala.collection.Set[FieldName] = _staticFieldsWritten.keySet

private[this] val _jsNativeMembersUsed: mutable.Map[MethodName, Unit] = emptyThreadSafeMap
def jsNativeMembersUsed: scala.collection.Set[MethodName] = _jsNativeMembersUsed.keySet
Expand Down Expand Up @@ -1200,13 +1205,13 @@ final class Analyzer(config: CommonPhaseConfig, initial: Boolean,
}

def readFields(names: List[FieldName])(implicit from: From): Unit = {
fieldsRead ++= names
names.foreach(_fieldsRead.update(_, ()))
if (isInstantiated)
referenceFieldClasses(names)
}

def writeFields(names: List[FieldName])(implicit from: From): Unit = {
fieldsWritten ++= names
names.foreach(_fieldsWritten.update(_, ()))
if (isInstantiated)
referenceFieldClasses(names)
}
Expand Down Expand Up @@ -1423,12 +1428,14 @@ final class Analyzer(config: CommonPhaseConfig, initial: Boolean,

if (!dataInClass.staticFieldsRead.isEmpty) {
moduleUnit.addStaticDependency(className)
clazz.staticFieldsRead ++= dataInClass.staticFieldsRead
dataInClass.staticFieldsRead.foreach(
clazz._staticFieldsRead.update(_, ()))
}

if (!dataInClass.staticFieldsWritten.isEmpty) {
moduleUnit.addStaticDependency(className)
clazz.staticFieldsWritten ++= dataInClass.staticFieldsWritten
dataInClass.staticFieldsWritten.foreach(
clazz._staticFieldsWritten.update(_, ()))
}

if (!dataInClass.methodsCalled.isEmpty) {
Expand Down