Skip to content

Update dom/form data #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 1, 2023
Merged

Update dom/form data #800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3d9f133
Update FormData.scala
G-yhlee Jul 26, 2023
1f3526c
Update api-reports
G-yhlee Jul 26, 2023
31c026c
Update FormData.scala - using function overloading
G-yhlee Jul 26, 2023
3fc37fe
Update api-reports
G-yhlee Jul 26, 2023
8989d97
Add MDN documentation strings for FormData
zetashift Jul 26, 2023
60f2e98
Merge pull request #1 from scala-js/js-dom/formData
G-yhlee Jul 26, 2023
862b43e
Update FormData.scala
G-yhlee Jul 27, 2023
30cbe41
Update api-reports
G-yhlee Jul 27, 2023
aa5a898
Update FormData.scala
G-yhlee Aug 1, 2023
1582e48
Update FormData with add constructor
G-yhlee Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update FormData.scala
  • Loading branch information
@G-yhlee
G-yhlee committed Aug 1, 2023
commit aa5a8985338d44ac5fbaf85796e4bdebfe85299f
6 changes: 3 additions & 3 deletions api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2291,16 +2291,16 @@ FocusEventInit[JT] var scoped: js.UndefOr[Boolean]
FocusEventInit[JT] var view: js.UndefOr[Window]
FocusOptions[JT] var focusVisible: js.UndefOr[Boolean]
FocusOptions[JT] var preventScroll: js.UndefOr[Boolean]
FormData[JC] def append(name: String, value: Blob, blobName: String): Unit
FormData[JC] def append(name: String, value: Blob, blobName: String?): Unit
FormData[JC] def append(name: String, value: String): Unit
FormData[JC] def delete(name: String): Unit
FormData[JC] def entries(): js.Iterator[js.Tuple2[String, String | Blob]]
FormData[JC] def get(name: String): String | Blob
FormData[JC] def getAll(name: String): js.Array[String | Blob]
FormData[JC] def has(name: String): Boolean
FormData[JC] @JSName(js.Symbol.iterator) override def jsIterator(): js.Iterator[js.Tuple2[String, String]]
FormData[JC] @JSName(js.Symbol.iterator) override def jsIterator(): js.Iterator[js.Tuple2[String, String | Blob]]
FormData[JC] def keys(): js.Iterator[String]
FormData[JC] def set(name: String, value: Blob, blobName: String): Unit
FormData[JC] def set(name: String, value: Blob, blobName: String?): Unit
FormData[JC] def set(name: String, value: String): Unit
FormData[JC] def values(): js.Iterator[String | Blob]
FormData[JO]
Expand Down
6 changes: 3 additions & 3 deletions api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2291,16 +2291,16 @@ FocusEventInit[JT] var scoped: js.UndefOr[Boolean]
FocusEventInit[JT] var view: js.UndefOr[Window]
FocusOptions[JT] var focusVisible: js.UndefOr[Boolean]
FocusOptions[JT] var preventScroll: js.UndefOr[Boolean]
FormData[JC] def append(name: String, value: Blob, blobName: String): Unit
FormData[JC] def append(name: String, value: Blob, blobName: String?): Unit
FormData[JC] def append(name: String, value: String): Unit
FormData[JC] def delete(name: String): Unit
FormData[JC] def entries(): js.Iterator[js.Tuple2[String, String | Blob]]
FormData[JC] def get(name: String): String | Blob
FormData[JC] def getAll(name: String): js.Array[String | Blob]
FormData[JC] def has(name: String): Boolean
FormData[JC] @JSName(js.Symbol.iterator) override def jsIterator(): js.Iterator[js.Tuple2[String, String]]
FormData[JC] @JSName(js.Symbol.iterator) override def jsIterator(): js.Iterator[js.Tuple2[String, String | Blob]]
FormData[JC] def keys(): js.Iterator[String]
FormData[JC] def set(name: String, value: Blob, blobName: String): Unit
FormData[JC] def set(name: String, value: Blob, blobName: String?): Unit
FormData[JC] def set(name: String, value: String): Unit
FormData[JC] def values(): js.Iterator[String | Blob]
FormData[JO]
Expand Down
8 changes: 4 additions & 4 deletions dom/src/main/scala/org/scalajs/dom/FormData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import scala.scalajs.js.|
*/
@js.native
@JSGlobal
class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[String, String]] {
class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[String, String | Blob]] {

/** The `append()` method of the `FormData` interface appends a new value onto an existing key inside a `FormData`
* object, or adds the key if it does not already exist.
Expand All @@ -41,7 +41,7 @@ class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[
* The filename reported to the server (a string), when a `Blob` or `File` is passed as the second parameter. The
* default filename for `Blob` objects is "blob". The default filename for `File` objects is the file's filename.
*/
def append(name: String, value: Blob, blobName: String): Unit = js.native
def append(name: String, value: Blob, blobName: String = js.native): Unit = js.native

/** The `delete()` method of the `FormData` interface deletes a key and its value(s) from a `FormData` object.
* @param name
Expand Down Expand Up @@ -89,11 +89,11 @@ class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[
* The field's value.
*/
def set(
name: String, value: Blob, blobName: String
name: String, value: Blob, blobName: String = js.native
): Unit = js.native

@JSName(js.Symbol.iterator)
override def jsIterator(): js.Iterator[js.Tuple2[String, String]] = js.native
override def jsIterator(): js.Iterator[js.Tuple2[String, String | Blob]] = js.native

/** The `FormData.entries()` method returns an iterator which iterates through all key/value pairs contained in the
* `FormData`. The key of each pair is a string object, and the value is either a string or a `Blob`.
Expand Down