Refresh DataTransfer API #763
Conversation
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
| /** Adds a new entry for the given data to the drag data store. If the data is plain text then a type string has to be | ||
| * provided also. | ||
| */ | ||
| def add(data: File): Unit = js.native |
There was a problem hiding this comment.
MDN says this has a defined return value :)
A DataTransferItem containing the specified data. If the drag item couldn't be created (for example, if the associated DataTransfer object has no data store), null is returned.
https://developer.mozilla.org/en-US/docs/Web/API/DataTransferItemList/add#return_value
api-reports/2_12.txt
Outdated
| DataTransfer[JT] var dropEffect: DropEffectValue | ||
| DataTransfer[JT] var effectAllowed: EffectAllowedValue |
There was a problem hiding this comment.
Ok, after many sleepless nights I propose:
DataTransferDropEffectKindDataTransferEffectAllowedKind
Rationale:
- Prefix with
DataTransferto "namespace" them. Since we are just making these names up, there's no guarantee that there won't be some other unrelatedDropEffectorEffectAllowedAPI added in the future, that would clash with the name. - Postfix with
Kind, because the spec describes it as "the kind of operation". Furthermore, looking through other enums we've facaded, we have various "kinds" but not any "values".
WDYT?
There was a problem hiding this comment.
The prefix to namespace sounds extremely meh, but I can't argue with that reasoning :P.
And yes postfixing with Kind sounds great!
There was a problem hiding this comment.
The prefix to namespace sounds extremely me
Heh yeah, welcome to browsers where everything is in the global namespace 😛 anyway we have various precedents for doing that as well, some of which I think has been copied from spec/TS/something 🤔
2 participants
Should resolve #738