Skip to content

Makes typed view holders use newer findViewById on api >= 26. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2017
Merged

Makes typed view holders use newer findViewById on api >= 26. #319

merged 2 commits into from
Sep 7, 2017

Conversation

gregghz
Copy link
Contributor

@gregghz gregghz commented Sep 5, 2017

fixes #317

@pfn
Copy link
Member

pfn commented Sep 7, 2017

Thanks, but this is incomplete. It's missing the bottom case that handles LayoutInclude. Can you please update?

@gregghz
Copy link
Contributor Author

gregghz commented Sep 7, 2017

@pfn sure, just updated it.

@pfn pfn changed the base branch from master to 1.7.x September 7, 2017 19:20
@pfn pfn changed the base branch from 1.7.x to master September 7, 2017 19:21
@pfn pfn merged commit 7725d85 into scala-android:master Sep 7, 2017
pfn pushed a commit that referenced this pull request Sep 7, 2017
@gregghz @pfn
Makes typed view holders use newer findViewById on api >= 26. (#319)
6744c48 
fixes #317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android O View gets inferred to Nothing in viewHolders.scala

2 participants

@gregghz @pfn