Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts, eslint, prettier #963

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Update ts, eslint, prettier #963

wants to merge 17 commits into from

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Oct 11, 2024

Description

  • updated typescript and eslint/prettier related deps
  • removed @typescript-eslint/eslint-plugin from nextjs package.json since it's already included to eslint-config-next
  • explicit "plugins": ["@trivago/prettier-plugin-sort-imports"] to avoid warnings. From docs
  • added check-types script for hardhat
  • a little bit formatting/fix types and disabled eslint for a few places after updates

Note: eslint v9 is still not supported by nextjs, so I used last v8 version

To test take code snippet here

Additional Information

Related Issues

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rin-st!!

Just added a couple of comments

Also in tailwind.config.js I see an error but on main it doesn't seem to appear:

Screenshot 2024-10-16 at 8 34 52 PM

Also maybe its good chance to solve this warnings in .eslintrc files ?

Screenshot 2024-10-16 at 8 29 54 PM

present at both nextjs and hardhat.


Also pushed a minor commit not related to this PR fixing the types of useScaffoldEventHistory

packages/nextjs/package.json Outdated Show resolved Hide resolved
packages/hardhat/package.json Outdated Show resolved Hide resolved
@rin-st
Copy link
Member Author

rin-st commented Oct 17, 2024

Thanks for the great comments!

Also maybe its good chance to solve this warnings in .eslintrc files ?

7c82a33

Also in tailwind.config.js I see an error but on main it doesn't seem to appear:

It turns out that by default next lint checks only some folders but not the full nextjs dir. I changed it 9599964, so all the nextjs folder is linted now, including tailwind.config.js

Plus:

  • Removed parser which is already included into eslint-config-next (parser) and eslint rule included to typescript-eslint:recommended (which again included to eslint-config-next)
  • I met bug: ESLint Error #901 again. I changed prettier file to .prettierrc.js and changed import, because of @trivago/prettier-plugin-sort-imports causes bug with underlines in vscode. It's a pity that I couldn't find it earlier, maybe bug: ESLint Error #901 wont even started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants