Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding issue when converting to wei #940

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

lukaw3d
Copy link
Contributor

@lukaw3d lukaw3d commented Sep 16, 2024

Description

Related to #894 #893

https://abi.ninja/0xde30da39c46104798bb5aa3fe8b9e0e1f348163f/1?methods=transfer

abi ninja_0xde30da39c46104798bb5aa3fe8b9e0e1f348163f_1_methods=transfer abi ninja_0xde30da39c46104798bb5aa3fe8b9e0e1f348163f_1_methods=transfer (1)

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

@technophile-04
Copy link
Collaborator

Thanks @lukaw3d for finding and fixing! Also @rin-st for suggestion! Merging this 🙌

@technophile-04 technophile-04 merged commit 2467dfb into scaffold-eth:main Sep 23, 2024
1 check passed
@lukaw3d lukaw3d deleted the lw/fix-rounding-2 branch October 4, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants