Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up next react sept 24 #933

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Up next react sept 24 #933

merged 6 commits into from
Sep 17, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Sep 10, 2024

Description

Step 2 of #917 (comment)

Decided to combine next/react with CSS libs or we will have 15 pull requests just to update dependencies

Plus

  • updated react-copy-to-clipboard types since it's broken with newest react
  • updated vercel version
  • updated viem, wagmi and rainbowkit last patches

Additional Information

@rin-st
Copy link
Member Author

rin-st commented Sep 14, 2024

Note: need to update all the pr related libs again before test/merge

@technophile-04
Copy link
Collaborator

Note: need to update all the pr related libs again before test/merge

Yup makes sense! Thanks @rin-st! Will review/test it as soon you push the update commit, also no rush at all!!

@rin-st
Copy link
Member Author

rin-st commented Sep 15, 2024

Yup makes sense! Thanks @rin-st! Will review/test it as soon you push the update commit, also no rush at all!!

Updated!

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ @rin-st !! 🙌 Tested in vercel-sepolia and is working nicely to me.

In the vercel development site at some point I checked console and I was getting spamming errors, (I think they're related to Metamask) but I haven't noticed any bad behaviour.

image

Will try to reproduce later tonight, I tried a couple times and couldn't reproduce 🙏

@rin-st
Copy link
Member Author

rin-st commented Sep 15, 2024

Thank you for testing! I cannot access second link and check it (I don't need it if no errors)
image

Will try to reproduce later tonight, I tried a couple times and couldn't reproduce 🙏

Tried to reproduce it too, no luck

@rin-st
Copy link
Member Author

rin-st commented Sep 15, 2024

wrote lockdown-install.js to google and every link tells that it's because of metamask. For example here

@Pabl0cks
Copy link
Collaborator

I couldn't reproduce it either, so maybe it was some random error from my metamask.

Trying to reproduce it i realized the collapse icon is not showing in the right place in /debug txReceipt.

Screenshot

image

@rin-st
Copy link
Member Author

rin-st commented Sep 16, 2024

Trying to reproduce it i realized the collapse icon is not showing in the right place in /debug txReceipt.

Fixed it + arrow in tuple and tuple arrays

before:

Screenshot 2024-09-16 at 12 07 38

after:

Screenshot 2024-09-16 at 13 06 21
Contract to test


contract TestContract {
	struct Data {
		uint256 id;
		string name;
	}

	// Method with a struct parameter
	function methodWithTuple(
		Data memory data
	) public pure returns (uint256, string memory) {
		return (data.id, data.name);
	}

	// Method with an array of struct parameter
	function methodWithArrayOfTuples(
		Data[] memory dataArray
	) public pure returns (Data[] memory) {
		return dataArray;
	}
}

Deployment file

import { HardhatRuntimeEnvironment } from "hardhat/types";
import { DeployFunction } from "hardhat-deploy/types";

const deployTestContract: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
  const { deployer } = await hre.getNamedAccounts();
  const { deploy } = hre.deployments;

  await deploy("TestContract", {
    from: deployer,
    args: [],
    log: true,
    autoMine: true,
  });
};

export default deployTestContract;

deployTestContract.tags = ["TestContract"];


Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rin-st !! Tested it nicely and works great!

https://up-next-psi.vercel.app/

I was getting spamming errors, (I think they're related to Metamask) but I haven't noticed any bad behaviour.

Ohh I have kind of seen this sometime not sure why its happens but I think it happens only in rare cases that to on vercel gated URL's on actual open to all domains haven't encountered it. So feel nothing to very that much about but we could keep a look and tackle it sometime

@technophile-04 technophile-04 merged commit fe5f269 into main Sep 17, 2024
1 check passed
@technophile-04 technophile-04 deleted the up-next-react-sept-24 branch September 17, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants