Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you
cd packages/nextjs
and runyarn build
it fails,The reason was
baseUrl
which we were generating for metadata.This PR adds a fallback port, similar to how next
metadataBase
default works.Btw we need
baseUrl
since OpenGraph.image and Twitter.image they both absoulte path and passing just/thumbnail.jpg
does not work, check out code commet here.Closes #748