Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly CLI backmerge #593

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Weekly CLI backmerge #593

merged 8 commits into from
Nov 2, 2023

Conversation

carletex
Copy link
Member

@carletex carletex commented Nov 2, 2023

Updating the CLI branch with:

@carletex carletex changed the base branch from main to cli November 2, 2023 09:58
@carletex carletex marked this pull request as ready for review November 2, 2023 11:52
@technophile-04
Copy link
Collaborator

technophile-04 commented Nov 2, 2023

Tysm Carlos 🙌 tested it nicely and works great !! Once we merge #594 and update it here I think it's ready to go 🙌

https://foundy-external-contracts.vercel.app

Btw we should also upgrade the next version to at least 13.4.6 because daisyUI styles break on next build output (related issue saadeghi/daisyui#2303 (comment))

Screenshot 2023-11-02 at 9 09 28 PM

No need to wait for this, will create a PR for it and test it over the weekend, and in next's week CLI backmerge we can publish those changes 🙌

@carletex
Copy link
Member Author

carletex commented Nov 2, 2023

Once we merge #594 and update it here I think it's ready to go 🙌

Added a comment there!

Btw we should also upgrade the next version to at least 13.4.6 because daisyUI styles break on next build output (related issue saadeghi/daisyui#2303 (comment))

Is this happening for you here? https://foundy-external-contracts.vercel.app/

It works for me:
image

Thanks!

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this happening for you here? https://foundy-external-contracts.vercel.app/

yeah try clicking and holding on one of the options :

Screen.Recording.2023-11-02.at.9.46.59.PM.mov

Also in your SS see how

there is lot of extra space above copy address :
280052136-b7a2fb8e-cb79-47f5-934f-d2fb55b9a3a1

This is how it looks on localhost:
Screenshot 2023-11-02 at 9 51 00 PM

Lol sorry for being soo nitpicky 😂, nevertheless I think we can merge this 🙌

@technophile-04 technophile-04 merged commit 06ba1eb into cli Nov 2, 2023
@technophile-04 technophile-04 deleted the cli-backmerge branch November 2, 2023 16:29
@technophile-04 technophile-04 mentioned this pull request Nov 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants