Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: footer missalignment on mobile screens #502

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

technophile-04
Copy link
Collaborator

Description

Removed the padding-x so as to have greater space on mobile screens (updated version #501 ) :

Screenshot 2023-08-23 at 11 44 25 PM

Additional Information

Related Issues

fixes #497

Your ENS/address: shivbhonde.eth

@technophile-04
Copy link
Collaborator Author

Pushed some minor tweaks to solve the footer on very small devices :

Screen.Recording.2023-08-24.at.11.43.47.AM.mov

Also solved the packages/nextjs/pages/index.tsx on Home pages was not wrapping on smaller devices and was breaking out screen

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some minor tweaks to solve the footer on very small devices

Also solved the packages/nextjs/pages/index.tsx on Home pages was not wrapping on smaller devices and was breaking out screen

Awesome job! Looks great 🙌

@technophile-04 technophile-04 merged commit 2e15c39 into main Aug 24, 2023
1 check passed
@technophile-04 technophile-04 deleted the ctteck/main branch August 24, 2023 08:53
@Pabl0cks Pabl0cks restored the ctteck/main branch August 29, 2023 11:14
@technophile-04 technophile-04 deleted the ctteck/main branch August 29, 2023 11:22
damianmarti pushed a commit that referenced this pull request Sep 7, 2023
* Fix RainbowKitCustomConnectButton dropdown styles (#500)

* chore: footer missalignment & home page on small screens  (#502)

Co-authored-by: CJ <53488449+0xChijoke@users.noreply.github.com>

* Update and typescript version (#499)

* update typescript and viem version

* update next config

* fix: header links wrapping icons and text (#510)

* Fix typos in useScaffoldContractWrite logs (#512)

* fix: spelling in test file name (#522)

* add suport for verify in foundry similar to hardhat

* update git task title when using foundry

* add changeset

* update changeset

---------

Co-authored-by: Rinat <rinat@hey.com>
Co-authored-by: CJ <53488449+0xChijoke@users.noreply.github.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Footer misalignment for small screens(mobile)
3 participants