-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced README for Docs-website launch #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good to me Pablo !!!, I think it is ready to merge but let's get one more opinion too 🙌
For the links, I was with the mindset of don't have this PR merged until Austin points the prod domain and subdomain to both the website and the docs. If you see it better, I can update to the vercel domain and then update the links to prod whenever they are ready.
Thanks! Sure! |
Yup yup I agree, I will talk with Austin 🙌 |
Thanks @Pabl0cks everything looks great!! One small comment. The link to the documentation below the Quickstart section looks a little small there. Maybe is better to add a Documentation section, and add the link to the documentation and the website there again (I know that these links are at the README start, but maybe the people can miss it there). Thanks! |
Thanks for the feedback @damianmarti ♥ Agree with you, that sentence with docs link after Quickstart section won't catch the eye from the people that missed the first link. I've just pushed the change to add Documentation section before Contributing. Note: If we add the website link to Scaffold-ETH 2 repo in the future, we probably should delete that website mention from the Documentation section. |
We have configured the DNS, scaffholdeth.io and docs.scaffoldeth.io point new website and docs Tysm all, Merging this 🙌 |
Description
First version of the SE-2 Website and Documentation Website are ready to launch, so we need to reduce our current README and add links to the Docs on it.
Additional Information
Related Issues
Closes #474
Your ENS/address: pabl0cks.eth