-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New shadow-center utility class for dropdown/notifications #455
Conversation
What is wrong in the dark theme? I chose the In the notification, I think it looks better. For the dropdown, maybe we could change the bg to bg-200, so it has more contrast: Let's see what others think too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cute and nice to me !!
For the dropdown, maybe we could change the bg to bg-200, so it has more contrast:
Yup, this looks better
we have a glowy shadow in the light mode so in the dark mode having it too makes sense
Darkmode also looks cool to me 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new look for the notifications/dropdown!
For the dropdown, maybe we could change the bg to bg-200, so it has more contrast:
Yeah I think it looks better with bg-200.
now it's better :) |
Thanks all!! <3 |
Fixes #441
I discussed several options with Andrea, to make the dropdown / notifications look better (they were mixing with the background).
We ended up adding a new shadow utility class
shadow-center
that combined with ashadow-accent
(or `shadow-{primary|secondary|etc..}) gives a nice effect.Notifications:
Dropdown menu: (Also made the dropdown menu items smaller and adjust the border radius (we can also apply this to #446))
What do you all think?