Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shadow-center utility class for dropdown/notifications #455

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

carletex
Copy link
Member

Fixes #441

I discussed several options with Andrea, to make the dropdown / notifications look better (they were mixing with the background).

We ended up adding a new shadow utility class shadow-center that combined with a shadow-accent (or `shadow-{primary|secondary|etc..}) gives a nice effect.

Notifications:
Screenshot from 2023-07-27 12-23-25

Dropdown menu: (Also made the dropdown menu items smaller and adjust the border radius (we can also apply this to #446))

image

What do you all think?

@rin-st
Copy link
Member

rin-st commented Jul 27, 2023

Looks good! But not for the dark theme

accent color:
Снимок экрана 2023-07-27 в 19 25 33
Снимок экрана 2023-07-27 в 19 37 21

primary color:
Снимок экрана 2023-07-27 в 19 33 56
Снимок экрана 2023-07-27 в 19 36 58

it seems we need to add new color for shadows

@carletex carletex mentioned this pull request Jul 27, 2023
2 tasks
@carletex
Copy link
Member Author

Looks good! But not for the dark theme

What is wrong in the dark theme? I chose the accent since it was the best one (more contrast) in the dark theme.

main:
image

this pr:
image

main:
image

this pr:
image


In the notification, I think it looks better.

For the dropdown, maybe we could change the bg to bg-200, so it has more contrast:

image


Let's see what others think too.

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cute and nice to me !!

For the dropdown, maybe we could change the bg to bg-200, so it has more contrast:

Yup, this looks better

we have a glowy shadow in the light mode so in the dark mode having it too makes sense

Darkmode also looks cool to me 🙌

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new look for the notifications/dropdown!

For the dropdown, maybe we could change the bg to bg-200, so it has more contrast:

Yeah I think it looks better with bg-200.

@rin-st
Copy link
Member

rin-st commented Jul 27, 2023

For the dropdown, maybe we could change the bg to bg-200, so it has more contrast:

now it's better :)

@carletex
Copy link
Member Author

Thanks all!! <3

@carletex carletex merged commit aa31a6c into main Jul 27, 2023
1 check passed
@carletex carletex deleted the 441-better-notifications-dropdowns branch July 27, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better notifications / dropdowns
4 participants