fix eth_accounts calls on localNetwork

[technophile-04]

Description

Since we have localWalletClient as use effect dependency we get lot of eth_accounts because of this line :

scaffold-eth-2/packages/nextjs/components/scaffold-eth/Faucet.tsx

Line 35 in 6370b4c

const accounts = await localWalletClient.getAddresses();

You can easily notice lot of eth_accounts while using SE-2 through CLI but for some reason on main it sometimes doesn't happens directly and if you add console.log("This is localWalletClient", localWalletClient) below the above permalink it will start making eth_accounts (😅 even I am confused about this behavior on main but I noticed on it on main)

Nevertheless, I think it makes sense not to pass objects as dependency to useEffect

Solution :

Move localWalletClient outside of the component this we don't need to pass it as a dependency.

JSON.stringify doesn't work because uid is changing in localWalletClient

{"chain" :  ........... "uid":"0f45556b091"}

[rin-st]

Good job! 👍
Please do the same for <FaucetButton /> or use the same wallet client if possible

[technophile-04]

Please do the same for or use the same wallet client if possible

I think we are not using useEffect in FaucetButton 😅 but moved localWalletClient outside the component at 9426ba2 🙌

[rin-st]

yes, but it created new client on every render :)

[carletex]

This fixes it! Since createWalletClient is not a hook I guess we are not supposed to use it as a dep because it changes every render.

Thank all!

[Pabl0cks]

Tested in the branch I noticed it yesterday, and fixed it. Nice job all! 🙌