Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scaffold eth configuration doc #384

Merged
merged 10 commits into from
Jul 17, 2023

Conversation

KcPele
Copy link
Contributor

@KcPele KcPele commented Jun 20, 2023

Description

Added a section in the readme.md that explains how to make use of scaffold-eth config file

Concise description of proposed changes, We recommend using screenshots and videos for better description
Screenshot from 2023-06-20 13-08-29

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:
kcpele.eth

@Pabl0cks
Copy link
Collaborator

Thank you for the contribution to the readme @KcPele, that's a important section that deserved to be added.

I am reviewing it and doing a few tweaks. Hopefully I can submit my contributions tomorrow.
If possible, I'll commit my contributions directly on your fork so that it gets added to your PR.

- Move the section under "Deploying your NextJS App" parent section
- Create a link on the Readme index
- Tweaks on the parameter descriptions and formatting
- Add extend and import explanation paragraph at the end
@Pabl0cks
Copy link
Collaborator

I've pushed a few tweaks on the Scaffold configuration section:

  • Move the section under "Deploying your NextJS App" parent section
  • Create a link on the Readme index
  • Tweaks on the parameter descriptions and formatting
  • Add extend and import explanation paragraph at the end

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rin-st rin-st mentioned this pull request Jul 7, 2023
2 tasks
…e and file and add walletConnectProjectId config explanation
@Pabl0cks
Copy link
Collaborator

Pabl0cks commented Jul 7, 2023

As a begginer I saw option 1 easier to implement, so adapted Shiv's example a bit and pushed it with a couple more changes:

  1. Added walletConnectProjectId config explanation.
  2. Fixed alchemyApiKey config explanation, with the right variable name and .env file.

@rin-st
Copy link
Member

rin-st commented Jul 7, 2023

@Pabl0cks
Copy link
Collaborator

Pabl0cks commented Jul 7, 2023

TYSM for letting me know @rin-st! I just pushed the changes of the Readme, documenting the changes in the config for burner wallets.

@KcPele
Copy link
Contributor Author

KcPele commented Jul 7, 2023

TYSM for letting me know @rin-st! I just pushed the changes of the Readme, documenting the changes in the config for burner wallets.

Have you made the changes?

@Pabl0cks
Copy link
Collaborator

Pabl0cks commented Jul 7, 2023

Have you made the changes?

Yeah, added the changes to the Readme on my previous commit

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm @Pabl0cks I think the updates looks great !!!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@carletex carletex merged commit 23be8bd into scaffold-eth:main Jul 17, 2023
1 check passed
@carletex
Copy link
Member

This is looking good, thanks all!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants