-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added scaffold eth configuration doc #384
Conversation
Thank you for the contribution to the readme @KcPele, that's a important section that deserved to be added. I am reviewing it and doing a few tweaks. Hopefully I can submit my contributions tomorrow. |
- Move the section under "Deploying your NextJS App" parent section - Create a link on the Readme index - Tweaks on the parameter descriptions and formatting - Add extend and import explanation paragraph at the end
I've pushed a few tweaks on the Scaffold configuration section:
|
…e and file and add walletConnectProjectId config explanation
As a begginer I saw option 1 easier to implement, so adapted Shiv's example a bit and pushed it with a couple more changes:
|
Hey, the config was changed. https://github.com/scaffold-eth/scaffold-eth-2/pull/412/files#diff-f8931f9d5d91829368ab5eaeaa5253e0924466bdd704fbec7ebbe72fa4cf710d Please update the readme accordingly |
TYSM for letting me know @rin-st! I just pushed the changes of the Readme, documenting the changes in the config for burner wallets. |
Have you made the changes? |
Yeah, added the changes to the Readme on my previous commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm @Pabl0cks I think the updates looks great !!!
This is looking good, thanks all!! |
Description
Added a section in the readme.md that explains how to make use of scaffold-eth config file
Concise description of proposed changes, We recommend using screenshots and videos for better description
Additional Information
Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address:
kcpele.eth