cli: allow any case extension name (#101)

scaffold-eth · Aug 24, 2024 · c56aac4 · c56aac4
1 parent 02d4758
commit c56aac4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/young-moose-move.md b/.changeset/young-moose-move.md
@@ -0,0 +1,5 @@
+---
+"create-eth": patch
+---
+
+cli: allow case-sensitive extension names
diff --git a/src/utils/external-extensions.ts b/src/utils/external-extensions.ts
@@ -7,7 +7,7 @@ import { SOLIDITY_FRAMEWORKS } from "./consts";
 // Gets the data from the argument passed to the `--extension` option.
 // e.g. owner/project:branch => { githubBranchUrl, githubUrl, branch, owner, project }
 export const getDataFromExternalExtensionArgument = (externalExtension: string) => {
-  if (CURATED_EXTENSIONS[externalExtension]) {
+  if (CURATED_EXTENSIONS[externalExtension.toLowerCase()]) {
     externalExtension = getArgumentFromExternalExtensionOption(CURATED_EXTENSIONS[externalExtension]);
   }
 

diff --git a/src/utils/parse-arguments-into-options.ts b/src/utils/parse-arguments-into-options.ts
@@ -86,8 +86,10 @@ export async function parseArgumentsIntoOptions(
 
   const project = args._[0] ?? null;
 
+  // use the original extension arg
+  const extensionName = args["--extension"] && rawArgs.slice(2).find(a => a.toLowerCase() === args["--extension"]);
   // ToDo. Allow multiple
-  const extension = args["--extension"] ? await validateExternalExtension(args["--extension"], dev) : null;
+  const extension = extensionName ? await validateExternalExtension(extensionName, dev) : null;
 
   if (!dev && extension && !CURATED_EXTENSIONS[args["--extension"] as string]) {
     console.log(