Carnival Creation#294
Open
Aklaran wants to merge 44 commits into
Open
Conversation
…into carnival-creation
sclark
approved these changes
Mar 31, 2019
sclark
left a comment
sclark
left a comment
Member
There was a problem hiding this comment.
Looks like the test isn't passing, but once it does, lgtm!
| @@ -0,0 +1,389 @@ | |||
| class CsvUpdater | |||
Member
There was a problem hiding this comment.
Does this need to be in models/ or can we put it in helpers?
Contributor
Author
There was a problem hiding this comment.
It can be put into helpers. I'll make this change
| @@ -0,0 +1,14 @@ | |||
| require 'test_helper' | |||
|
|
|||
| class CarnivalCreationControllerTest < ActionController::TestCase | |||
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.