Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Removal of Sphinxbase dependency and update Pocketsphinx to v5.0.3 #183

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

matt1432
Copy link

@matt1432 matt1432 commented Apr 2, 2024

This was originally supposed to just port the software to Nix, but I struggled to make it work at first because the dependencies are very old at this point.

So, I got rid of Sphinxbase because it is now deprecated, updated Pocketsphinx to v5.0.3 and fixed every breaking changes this update caused.

Also, since I only use Nix I can't test building the software in the normal way so there might be some problems there.

@matt1432 matt1432 marked this pull request as draft April 6, 2024 05:38
@shirshak55
Copy link

it gives error on macos arm m2.

      clang: warning: optimization flag '-fexpensive-optimizations' is not supported [-Wignored-optimization-argument]
      gizmo/media/audiodec.cpp:62:2: warning: 'avcodec_close' is deprecated [-Wdeprecated-declarations]
              avcodec_close(m_codecCtx);
              ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavcodec/avcodec.h:2386:1: note: 'avcodec_close' has been explicitly marked deprecated here
      attribute_deprecated
      ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavutil/attributes.h:100:49: note: expanded from macro 'attribute_deprecated'
      #    define attribute_deprecated __attribute__((deprecated))
                                                      ^
      gizmo/media/audiodec.cpp:103:16: error: no member named 'channel_layout' in 'AVFrame'
                      if (m_frame->channel_layout == 0)
                          ~~~~~~~  ^
      gizmo/media/audiodec.cpp:104:13: error: no member named 'channel_layout' in 'AVFrame'
                              m_frame->channel_layout
                              ~~~~~~~  ^
      gizmo/media/audiodec.cpp:105:46: error: no member named 'channels' in 'AVFrame'
                                      = av_get_default_channel_layout(m_frame->channels);
                                                                      ~~~~~~~  ^
      gizmo/media/audiodec.cpp:117:2: warning: 'av_init_packet' is deprecated [-Wdeprecated-declarations]
              av_init_packet(&packet);
              ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavcodec/packet.h:652:1: note: 'av_init_packet' has been explicitly marked deprecated here
      attribute_deprecated
      ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavutil/attributes.h:100:49: note: expanded from macro 'attribute_deprecated'
      #    define attribute_deprecated __attribute__((deprecated))
                                                      ^
      2 warnings and 3 errors generated.
      error: command '/usr/bin/clang++' failed with exit code 1
      
      ```

@shirshak55
Copy link

Other error:

      gizmo/media/audiodec.cpp:62:2: warning: 'avcodec_close' is deprecated [-Wdeprecated-declarations]
              avcodec_close(m_codecCtx);
              ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavcodec/avcodec.h:2386:1: note: 'avcodec_close' has been explicitly marked deprecated here
      attribute_deprecated
      ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavutil/attributes.h:100:49: note: expanded from macro 'attribute_deprecated'
      #    define attribute_deprecated __attribute__((deprecated))
                                                      ^
      gizmo/media/audiodec.cpp:103:16: error: no member named 'channel_layout' in 'AVFrame'
                      if (m_frame->channel_layout == 0)
                          ~~~~~~~  ^
      gizmo/media/audiodec.cpp:104:13: error: no member named 'channel_layout' in 'AVFrame'
                              m_frame->channel_layout
                              ~~~~~~~  ^
      gizmo/media/audiodec.cpp:105:46: error: no member named 'channels' in 'AVFrame'
                                      = av_get_default_channel_layout(m_frame->channels);
                                                                      ~~~~~~~  ^
      gizmo/media/audiodec.cpp:117:2: warning: 'av_init_packet' is deprecated [-Wdeprecated-declarations]
              av_init_packet(&packet);
              ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavcodec/packet.h:652:1: note: 'av_init_packet' has been explicitly marked deprecated here
      attribute_deprecated
      ^
      /opt/homebrew/Cellar/ffmpeg/7.0.2_1/include/libavutil/attributes.h:100:49: note: expanded from macro 'attribute_deprecated'
      #    define attribute_deprecated __attribute__((deprecated))
                                                      ^
      2 warnings and 3 errors generated.
      error: command '/usr/bin/clang++' failed with exit code 1
      [end of output]
      ```

@shirshak55
Copy link

Even if i supress warning I will just get this error:

no-deprecated-declarations
gizmo/media/audiodec.cpp:103:16: error: no member named 'channel_layout' in 'AVFrame'
if (m_frame->channel_layout == 0)
~~~~~~~ ^
gizmo/media/audiodec.cpp:104:13: error: no member named 'channel_layout' in 'AVFrame'
m_frame->channel_layout
~~~~~~~ ^
gizmo/media/audiodec.cpp:105:46: error: no member named 'channels' in 'AVFrame'
= av_get_default_channel_layout(m_frame->channels);
~~~~~~~ ^
3 errors generated.
error: command '/usr/bin/clang++' failed with exit code 1
[end of output]

@sc0ty
Copy link
Owner

sc0ty commented Oct 1, 2024

Thank you for your work, but regretfully I have to inform you I will no longer maintain this project. See #197 for more info.
Ofc you're free to fork it and work on your own.

@shirshak55
Copy link

shirshak55 commented Oct 1, 2024 via email

@sc0ty
Copy link
Owner

sc0ty commented Oct 1, 2024

What do you mean by deprecate whole repo? I just did that

@sambartik
Copy link

What do you mean by deprecate whole repo? I just did that

You can archive a repo in settings to make it read only. Additionally, it will display a banner when viewing the repo saying so.

@sc0ty
Copy link
Owner

sc0ty commented Oct 1, 2024

Didn't know about that. Looks like exactly what I need, thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants