Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade solidity version in tests to 0.8.x #843

Merged
merged 13 commits into from
Feb 2, 2024
Merged

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Feb 2, 2024

#839

  • Integration test are mostly using 0.8.17 now
  • Unit / instrumentation tests using 0.8.24
  • Removed some tests from the function instrumentation tests which were legacy parser regression tests
  • Upgraded Hardhat dev dep to 2.19.5 to address solc settings property bug

⚠️ The stack-too-deep test has been skipped, Hoping to resolve #715 for the next version by instrumenting with a viaIR compatible technique - it should be unskipped as part of that PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbed395) 95.85% compared to head (13020f3) 95.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          19       19           
  Lines        1061     1061           
=======================================
  Hits         1017     1017           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke merged commit 66082b3 into master Feb 2, 2024
3 checks passed
@cgewecke cgewecke deleted the upgrade-solidity branch February 2, 2024 19:46
@cgewecke cgewecke mentioned this pull request Feb 4, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting viaIR to true in solc results in zero coverage
2 participants