Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real Zeppelin (instead of fork) as E2E #557

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Oct 31, 2020

Closes #555

This should seamlessly become the Hardhat E2E when they go up.

Notes

  • Their codecov command is exiting 0 without uploading reports (good)
  • Initially installed with yarn (ignoring the package-lock) and the test run took twice as long (20m vs 10m). Something's going on there maybe.

@codecov-io
Copy link

codecov-io commented Nov 1, 2020

Codecov Report

Merging #557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          20       20           
  Lines         824      824           
=======================================
  Hits          818      818           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be11494...6bfb4ce. Read the comment docs.

@cgewecke cgewecke merged commit 6761556 into master Nov 1, 2020
@cgewecke cgewecke deleted the zeppelin-buidler-e2e branch November 1, 2020 00:50
@cgewecke cgewecke mentioned this pull request Nov 1, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Zeppelin as a Hardhat E2E
2 participants