-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command line input for tag management #185
Conversation
I'm not 100% sure of what the use case is here, nor do I 100% understand how the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to see this option documented in the README
.
|
||
> release with-defaults tag-default o | ||
> release with-defaults tag-default k | ||
> release with-defaults tag-default v0.1.0-debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this scripted tests - why does release with defaults
fail and release with-defaults tag-default a
also fail, but release with-defaults tag-default o
doesn't fail? What's so special about o
that makes it different to a
? I just don't get it. Could you add some comments here to explain what's being tested and what's going on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to add comments around.
src/main/scala/ReleasePlugin.scala
Outdated
@@ -136,17 +137,21 @@ object ReleasePlugin extends AutoPlugin { | |||
(Space ~> token("release-version") ~> Space ~> token(StringBasic, "<release version>")) map ParseResult.ReleaseVersion | |||
private[this] val NextVersion: Parser[ParseResult] = | |||
(Space ~> token("next-version") ~> Space ~> token(StringBasic, "<next version>")) map ParseResult.NextVersion | |||
private[this] val TagDefault: Parser[ParseResult] = | |||
(Space ~> token("tag-default") ~> Space ~> token(StringBasic, "<next version>")) map ParseResult.TagDefault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (Space ~> token("tag-default") ~> Space ~> token(StringBasic, "<next version>")) map ParseResult.TagDefault
+ (Space ~> token("tag-default") ~> Space ~> token(StringBasic, "<tag default>")) map ParseResult.TagDefault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right thanks
TL;DR Rationale |
done fixes and addressed comments. Thanks for taking care and for comments :-) |
CI failure looks spurious to me |
Ah, I get it now. Perhaps then a more descriptive name would be Also, this needs to be documented in the |
Done, thanks a lot for the feedback! :-) |
Thanks! |
Due to recent updates, could you please publish a release? |
Added command line arguments to pass default parameter on tagRelease Step.