Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Conversation

miguel-vila
Copy link
Contributor

I'm not sure this will do what I want, which is to add java sources. These java sources could be specific to a customRow (e.g. versions of a java library), but they are not specific to the scala version.

@miguel-vila miguel-vila force-pushed the add-java-source-folders branch from 745ee2c to 52ade2e Compare December 22, 2023 20:54
@miguel-vila miguel-vila force-pushed the add-java-source-folders branch from 52ade2e to 8abda9f Compare December 22, 2023 20:54
@eed3si9n
Copy link
Member

There's scripted test (see https://www.scala-sbt.org/1.x/docs/Testing-sbt-plugins.html) for custom row in https://github.com/sbt/sbt-projectmatrix/blob/develop/src/sbt-test/projectMatrix/custom/build.sbt. Could you add a test there plz?

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 7181625 into sbt:develop Dec 27, 2023
@kubukoz
Copy link
Contributor

kubukoz commented Jan 2, 2024

Hey @eed3si9n, are you able to create a patch release sometime soon? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants