Add and apply scalafmt #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
approved these changes
Jan 25, 2024
|
Sure thing, I have been doing the same in other sbt community plugins so it shouldn't be controversial |
I just disabled squash merging in the repo settings. |
mkurz
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there are other PR's open its highly likely they are still dead and/or they are trivial in size and with the amount of work being done on sbt-osgi its best to get the formatter in sooner rather than later.
As always, if you are going to merge make sure to do either a "Create a merge Commit" or "Rebase and Merge" but not "Squash and Merge" since I need to add the format commit byitself to a
.git-blame-ignore-revs. After PR is merged you can also add a branch check for theCode is formattedto prevent unformatted PR's being merged into main.