This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
++ should only aggregate compatible projects #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #3 being merged first.
When a user does:
Currently we build all projects with 2.11.5, regardless of whether they support it or not. This change means that in that situation, we only build projects that are configured to cross build against a Scala version that is binary compatible with 2.11.5.
Of course, another way to achieve this would be to first switch to a dummy project that only aggregated projects that support that version, but this negates that need to have such a dummy project.
Of course, this doesn't work if you:
But it's convenient. If a project is specified, then it builds it regardless of the support - perhaps we could make that an error though.