Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail "merging/merging" scripted test in travis-ci since December 2018 #356

Closed
xuwei-k opened this issue Jan 12, 2019 · 2 comments
Closed

Comments

@xuwei-k
Copy link
Member

xuwei-k commented Jan 12, 2019

🤔

https://travis-ci.org/sbt/sbt-assembly/jobs/478647768#L882

[info] [error] java.lang.Exception: file /tmp/sbt_419bffc2/a had wrong content:
[info] [error] 2
[info] [error] 1
[info] [error] 3
[info] [error] 1
[info] [error] *** instead of ***
[info] [error] 1
[info] [error] 2
[info] [error] 1
[info] [error] 3
[info] [error] 	at $94426f8c8ad71399f0ed$.mustContain(build.sbt:48)
[info] [error] 	at $94426f8c8ad71399f0ed$.$anonfun$testmerge$7(build.sbt:21)
[info] [error] 	at $94426f8c8ad71399f0ed$.$anonfun$testmerge$7$adapted(build.sbt:19)
[info] [error] 	at sbt.io.IO$.withTemporaryDirectory(IO.scala:475)

https://travis-ci.org/sbt/sbt-assembly/builds

travis-ci-build-logs

https://github.com/sbt/sbt-assembly/commits/master

master-branch-commit-log

@xuwei-k
Copy link
Member Author

xuwei-k commented Jan 12, 2019

Some MergeStrategy does not treat order of Seq[File]. I think order depends on classpath order. (maybe classpath order depends on sbt internal implementations 🤔)

Should we sort classpath in here?

@eed3si9n
Copy link
Member

I guess it makes sense to sort.

xuwei-k added a commit to xuwei-k/sbt-assembly that referenced this issue Jan 22, 2019
eed3si9n added a commit that referenced this issue Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants