This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Threaded centrality #987
Merged
Threaded centrality #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SohamTamba I guess we could do that, but we generally prefer to ensure the code is correct (passes tests) before we spend time reviewing it. |
|
The code looks fine, once merge conflicts are resolved I'll review again. |
SohamTamba
force-pushed
the
Threaded_Centrality
branch
2 times, most recently
from
0e0ff93
to
f05af8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 99.84% 99.84% +<.01%
==========================================
Files 75 75
Lines 2575 2605 +30
==========================================
+ Hits 2571 2601 +30
Misses 4 4 |
sbromberger
approved these changes
Aug 29, 2018
|
Awesome! Thanks, @SohamTamba ! |
SohamTamba
added a commit
to SohamTamba/LightGraphs.jl
that referenced
this pull request
Sep 3, 2018
sbromberger
pushed a commit
that referenced
this pull request
Sep 8, 2018
* OneTo * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Parallel BFS
SohamTamba
added a commit
to SohamTamba/LightGraphs.jl
that referenced
this pull request
Sep 9, 2018
SohamTamba
added a commit
to SohamTamba/LightGraphs.jl
that referenced
this pull request
Sep 9, 2018
* OneTo * fixes reverse (sbromberger#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (sbromberger#995) * SimpleGraph(SimpleGraph) plus tests. (sbromberger#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (sbromberger#1001) * fixes edgeiter equality (sbromberger#1002) * 32-bit compatibility (sbromberger#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (sbromberger#987) * misc doc fixes (sbromberger#1003) * Fix sbromberger#999 (sbromberger#1004) * Parallel BFS Generate Reduce
sbromberger
pushed a commit
that referenced
this pull request
Sep 9, 2018
* Fix kruskal_mst function for working with abstract graphs (#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Karger Min Cut (#988) * Fix misspelling. (#1005) * Fixed some bugs in simplecycles_hawick_james (#1007) * Add function to find short cycles (#1006) * Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up. * Update .zenodo.json Fix zenodo error * Parallel BFS with static and dynamic load balancing (#943) * OneTo * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Parallel BFS Generate Reduce
sbromberger
pushed a commit
that referenced
this pull request
Sep 17, 2018
* Fix kruskal_mst function for working with abstract graphs (#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Karger Min Cut (#988) * Fix misspelling. (#1005) * Fixed some bugs in simplecycles_hawick_james (#1007) * Add function to find short cycles (#1006) * Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up. * Update .zenodo.json Fix zenodo error * Parallel BFS with static and dynamic load balancing (#943) * OneTo * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Parallel BFS Generate Reduce * VertexCover
sbromberger
pushed a commit
that referenced
this pull request
Sep 24, 2018
* Fix kruskal_mst function for working with abstract graphs (#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Karger Min Cut (#988) * Fix misspelling. (#1005) * Fixed some bugs in simplecycles_hawick_james (#1007) * Add function to find short cycles (#1006) * Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up. * Update .zenodo.json Fix zenodo error * Parallel BFS with static and dynamic load balancing (#943) * OneTo * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Parallel BFS Generate Reduce * VertexCover
sbromberger
added a commit
that referenced
this pull request
Oct 3, 2018
* inflate * Vertex Cover (#949) * Fix kruskal_mst function for working with abstract graphs (#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Karger Min Cut (#988) * Fix misspelling. (#1005) * Fixed some bugs in simplecycles_hawick_james (#1007) * Add function to find short cycles (#1006) * Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up. * Update .zenodo.json Fix zenodo error * Parallel BFS with static and dynamic load balancing (#943) * OneTo * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Parallel BFS Generate Reduce * VertexCover * More examples... (#1014) * More examples... * Update core.jl shortcut to Digraph creation * Update bipartition.jl * More doctests (#1016) * Xrefs/examples again * More examples! (#1018) * Centrality examples (#1019) * Biconnectivity examples (#1021) * Examples for some operators (#1022) * Fixes https://github.com/JuliaGraphs/MetaGraphs.jl/issues/55 (#1023) * Fixes https://github.com/JuliaGraphs/MetaGraphs.jl/issues/55 (#1023)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented multi-threaded centrality measures as a part of my GSoC project.
I would prefer to resolve conflicts with master after the changes have been reviewed so I don't have to resolve conflicts it multiple times.
cc @somil55