-
Notifications
You must be signed in to change notification settings - Fork 176
refactor(translations): front-facing message translations #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is really good idea - move log messages to phrases and don't set obviously used language? |
@CrazyHackGUT Not sure if I understand the phrasing, but are you proposing that I do set global translation target. |
I propose use |
No need that. |
This moves a good majority of the front-facing messages to translations.
Motivation and Context
Allow ease of translations of hard-coded values. Also closes #582
How Has This Been Tested?
This has not been tested so far.
Types of changes
Checklist: