Skip to content

Conversation

@fbergmann
Copy link
Member

Description

This PR adds a _hasPrefix method to xmlnode and xmlattributes. It also fixes the documentation string,
to make clear that indeed NULL will be returned by _getPrefix if no prefix is present.

Motivation and Context

fixes #390

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating August 22, 2024 08:59
@skeating skeating merged commit bc7264b into development Aug 22, 2024
@skeating skeating deleted the add-xmlnode_hasPrefix branch August 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XMLNode_getPrefix unexpectedly returns NULL when prefix is absent

3 participants