Skip to content

Conversation

@fbergmann
Copy link
Member

Description

javabindings where not compiling when using the configure based process.

Motivation and Context

  • fixes an issue with swigdoc expression that is invalid
  • changes detection of openjdk on Darwin (since the JDK is no longer supplied by apple)

fixes #386

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

can be tested using ./configure --with-java && make

@fbergmann fbergmann requested a review from skeating August 19, 2024 10:34
@fbergmann fbergmann merged commit 70d2890 into development Aug 22, 2024
@fbergmann fbergmann deleted the fix-java-gnumake branch August 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JavaBindings dont build with gnumake && python 3.12

3 participants